Fix build with cfitsio
ClosedPublic

Authored by rkflx on Sep 26 2017, 11:53 PM.

Details

Summary

Out-of-source builds would fail, as well as builds with a recent GCC.

However, this is more of an emergency build fix. Including the moc file
instead of fixing the linking error is still a hack and should
be fixed properly (see D7305).

Test Plan
  • Builds on KDE Neon (GCC 5.4) as well as openSUSE Tumbleweed (GCC 7.1).
  • Out-of-source and in-source builds succeed.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Sep 26 2017, 11:53 PM
ngraham accepted this revision.Sep 27 2017, 12:11 AM

Confirmed that this fixes out-of-source builds for me. Good emergency fix, and yeah, we should still fix this the right way.

This revision is now accepted and ready to land.Sep 27 2017, 12:11 AM

Thanks for testing, I'll commit tomorrow (and also look at your other reviews – this was more important for now, and you are just too fast fixing things ;-)

This revision was automatically updated to reflect the committed changes.