Differential D7976

Highlighting indexer: factor out checks for smaller while loop
ClosedPublic
Actions

Authored by dhaumann on Sep 24 2017, 8:09 PM.

Details

Reviewers
vkrause
Commits
R216:4b6a5d89aa77: Highlighting indexer: factor out checks for smaller while loop
Summary

Reduce while loop that iterates over the XML elements. This helps
to reduce the logic in the loop, making it a bit more readable.
Additionally, this will allow us to add more checks in the future.

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Sep 24 2017, 8:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 24 2017, 8:09 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vkrause accepted this revision.Sep 25 2017, 1:26 PM
This revision is now accepted and ready to land.Sep 25 2017, 1:26 PM
Closed by commit R216:4b6a5d89aa77: Highlighting indexer: factor out checks for smaller while loop (authored by dhaumann). · Explain WhySep 25 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19902

View Options

src/indexer/katehighlightingindexer.cpp

Loading...