Some might expect at least argument 0 to be available
ClosedPublic
Actions

Authored by ervin on Jan 11 2016, 9:26 PM.

Details

Reviewers

Commits

Summary

This is the case of KCrash in fact, and it actually makes sense, this
argument is supposed to always be set.

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin retitled this revision from to Some might expect at least argument 0 to be available.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

I would call the variable argv0, this isn't a char** argv, so the naming is confusing.

bensi edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2016, 8:09 AM

Address dfaure's comment

dfaure edited edge metadata.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/features/cuke-steps.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1886	d6291f4		Jan 11 2016, 9:26 PM	★	★
Diff 2	1890	d6291f4	Address dfaure's comment	Jan 12 2016, 8:16 AM	★	★
Diff 3	1892	d6291f4	Commit rZANSHINa69bda13459ae66b6753ccd76e03b867a8ebd517	Jan 12 2016, 8:16 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b42685ae15a0	7f1bfe9915bc	d6291f492326	Kevin Ottens	Some might expect at least argument 0 to be available (Show More…)	Jan 11 2016, 9:24 PM