Introduce MimeTypeChecker::hasWantedMimeTypes
ClosedPublic
Actions

Authored by mwolff on Sep 21 2017, 2:54 PM.

Details

Reviewers

Commits

R165:fc8db03b57f2: Introduce MimeTypeChecker::hasWantedMimeTypes

Summary

This allows us to skip the slow MimeTypeChecker::wantedMimeTypes
call, which allocates a QStringList on every call. This removes
~200k temporary allocations that I see in one heaptrack file for
kmail.

Diff Detail

Repository

R165 Akonadi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mwolff created this revision.Sep 21 2017, 2:54 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 21 2017, 2:54 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

Thanks! Can go to stable.

This revision is now accepted and ready to land.Sep 21 2017, 3:18 PM

what branch is "stable"? 1.9?

Applications/17.08

Done, I presume you'll merge that into master?

Closed by commit R165:fc8db03b57f2: Introduce MimeTypeChecker::hasWantedMimeTypes (authored by mwolff). · Explain WhySep 22 2017, 7:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/libs/mimetypecheckertest.cpp (2 lines)
M			src/core/mimetypechecker.h (14 lines)
M			src/core/mimetypechecker.cpp (5 lines)
M			src/core/models/entitytreemodel_p.cpp (18 lines)