Make sure we don't crash when not using a filter
AbandonedPublic
Actions

Authored by kfunk on Jan 11 2016, 5:18 PM.

Details

Reviewers

Summary

I'm getting a crash and I couldn't really completely figure out the code,
although this looks like a sane solution and fixes my crash.

Test Plan

Executing a missing target doesn't automatically crash, all tests pass.

Repository

R33 KDevPlatform

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

apol retitled this revision from to Make sure we don't crash when not using a filter.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added a reviewer: kfunk.

I'll try to reproduce the crash.

outputview/outputexecutejob.cpp
230	This renders the new feature (passing your own IFilteringStrategy*) to the model unusable, doesn't it?
outputview/outputmodel.cpp
437	Double assert?
444	That's ok.

Does this patch solve your problem? https://phabricator.kde.org/D789

Issue solved by my other patch. See previous comment.

			Path	Packages
M			outputview/outputexecutejob.cpp (3 lines)
M			outputview/outputmodel.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1879	aee806f		Jan 11 2016, 5:18 PM	★	★