Don't crash if a client (legally) uses deleted global contrast manager
ClosedPublic
Actions

Authored by davidedmundson on Sep 20 2017, 1:17 PM.

Details

Reviewers

graesslin

Group Reviewers

Plasma

Commits

Summary

There is a race condition in the following situation:

global)

Simultaneously:
- The client uses this resource
- The server deletes the global

This was fixed for Blur, but as mention in that commit can also happen here.
Code is effectively a copy and paste from eaac3948f1499b638799f05b6b229ee30b02eb9a

Test Plan

Unit test. Booted normal session

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Sep 20 2017, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Found a better approach that we can use globally (pun not intended)

If we track resources, we can re-call wl_set_implementation with a nullpointer in the callback for in the global destructor.

			Path	Packages
M			autotests/client/test_wayland_registry.cpp (27 lines)
M			src/server/contrast_interface.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19690	eaac394		Sep 20 2017, 1:17 PM	★	★
Diff 2	19696	eaac394	R127:403f60929f11ebd7deeb2792515b08df471fa656	Sep 20 2017, 1:17 PM	★	★