Differential D787

Properly set modality on AuthDialog
ClosedPublic
Actions

Authored by graesslin on Jan 11 2016, 4:02 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R121:2abe1fe105d0: Properly set modality on AuthDialog
Summary

The modality was set through KWindowSystem before the window was mapped
by Qt causing Qt to operwrite the X11 property.

This change sets the modality through Qt API, so that Qt itself sets
the X11 property.

Test Plan

Together with KAuth review we get parent and modality set correctly again

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 1875.Jan 11 2016, 4:02 PM
graesslin retitled this revision from to Properly set modality on AuthDialog.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a subscriber: plasma-devel.
graesslin edited the test plan for this revision. (Show Details)Jan 11 2016, 4:04 PM
graesslin added reviewers: davidedmundson, Plasma.
graesslin added a project: Plasma.
davidedmundson accepted this revision.Jan 16 2016, 4:05 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2016, 4:05 PM
Closed by commit R121:2abe1fe105d0: Properly set modality on AuthDialog (authored by graesslin). · Explain WhyJan 25 2016, 9:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MAuthDialog.cpp (2 lines)

Diff 2087

View Options

AuthDialog.cpp

Loading...