This change will fix clojure's syntax highlighting like the following code:
(@(.state this) k)
Currently, @(.state is recognized as a reader macro, but it has to consider brackets.
dhaumann |
This change will fix clojure's syntax highlighting like the following code:
(@(.state this) k)
Currently, @(.state is recognized as a reader macro, but it has to consider brackets.
Lint Skipped |
Unit Tests Skipped |
In general looks good, but 2 issues:
Hi,
I updated the patch.
However, some errors happen in clojure's test.
These errors also happened in the previous revision.
Start 1: appstreamtest 1/9 Test #1: appstreamtest .................... Passed 0.02 sec Start 2: wildcardmatcher_test 2/9 Test #2: wildcardmatcher_test ............. Passed 0.01 sec Start 3: syntaxrepository_test 3/9 Test #3: syntaxrepository_test ............ Passed 0.46 sec Start 4: theme_test 4/9 Test #4: theme_test ....................... Passed 0.01 sec Start 5: testhighlighter_test 5/9 Test #5: testhighlighter_test .............***Failed 1.80 sec Start 6: htmlhighlighter_test 6/9 Test #6: htmlhighlighter_test ............. Passed 2.13 sec Start 7: folding_test 7/9 Test #7: folding_test ..................... Passed 2.52 sec Start 8: highlighter_benchmark 8/9 Test #8: highlighter_benchmark ............ Passed 3.06 sec Start 9: repository_benchmark 9/9 Test #9: repository_benchmark ............. Passed 0.31 sec
build/Testing/Temporary/LastTest.log:
QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "DocumentationPossible" in context "DocumentationPossible" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "DocumentationPossible" in context "DocumentationPossible" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "Documentation Char" in context "Documentation" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "Documentation Char" in context "Documentation" of definition "Clojure" .... .... FAIL! : TestHighlighterTest::cleanupTestCase() 'coveredList.open(QFile::WriteOnly)' returned FALSE. () Loc: [/home/koichi/Desktop/kde-syntax-highlighting/syntax-highlighting/autotests/testhighlighter.cpp(103)]
@koichia For me, the unit tests pass. And it's also green on https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/97/