FEATURE: 357626
Remove bookmark from popup menu added
Details
Details
- Reviewers
aacid - Group Reviewers
Okular - Commits
- R223:a57ffdbd959c: added the "remove this bookmark" to bookmarks section
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Please make the summary be correct according https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
part.cpp | ||
---|---|---|
2206 | Why commented code? |
part.cpp | ||
---|---|---|
2187 | Any reason you're not just calling BookmarkManager::removeBookmark( const DocumentViewport &vp ); ? |
Comment Actions
Sorry for such a mess. First time commiting
part.cpp | ||
---|---|---|
2187 | Just checked with that. It works, but on my machine there were some "slow responding". Not sure, if it just because of lot memory used. But anyway, here goes new diff | |
2206 | Actually, not sure, if need this lines. Okay, I'll remove, since it works without it |
Comment Actions
I have to ask, i need your real name to give you proper copyright attribution and "Lex Dem" doesn't really look like a russian name, could you please confirm your real name?