Add extra visual indicator for Checkbox/Radio keyboard focus
ClosedPublic
Actions

Authored by davidedmundson on Sep 14 2017, 2:38 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

R242:ee2b12be0456: Add extra visual indicator for Checkbox/Radio keyboard focus

Summary

This draws a line underneath a Plasma checkbox label when it has
keyboard focus. This is needed as when an item is checked, the focus
shadow is practically invisible.

Visuals when clicking is completely unchanged
This brings it more in line with our QStyle.

Test Plan

Attached runtime tests

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Sep 14 2017, 2:38 PM

Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptSep 14 2017, 2:38 PM

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

See second line attached:

mart accepted this revision.Sep 18 2017, 9:12 AM

This revision is now accepted and ready to land.Sep 18 2017, 9:12 AM

Closed by commit R242:ee2b12be0456: Add extra visual indicator for Checkbox/Radio keyboard focus (authored by davidedmundson). · Explain WhySep 19 2017, 12:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/declarativeimports/plasmastyle/CheckBoxStyle.qml (8 lines)
M		src/declarativeimports/plasmastyle/RadioButtonStyle.qml (8 lines)
A	M	tests/components/checkbox.qml (68 lines)
A	M	tests/components/radiobutton.qml (60 lines)