Make Kickoff expose items to accessibility

Authored by davidedmundson on Sep 12 2017, 8:25 AM.



FocusProxy is added to all the Baseviews as an effective focus proxy to
forward focus to the contained Scrollview which in turn forwards it to
the relevant list view.

This gives focus to the relevant delegate.

Both tabs and items are exposed to the accessibilty tree.

Key handling still needs improvement, but that's somewhat separate.

Test Plan

Orca tells me tab when I change, and item when I change item

Diff Detail

R119 Plasma Desktop
No Linters Available
No Unit Test Coverage
davidedmundson created this revision.Sep 12 2017, 8:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2017, 8:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson planned changes to this revision.Sep 12 2017, 10:45 AM
davidedmundson added inline comments.


I did this because FullScreenRep was setting focus on this item explicitly.
but given that was rubbish and I'm redoing it anyway I don't need to.

In the old code sometimes the root item would mostly have focus,
sometimes the relevant object. The root item would then perform key
handling for everyone and dispatch events to the relevant place.

Because focus kept ending up in the wrong place and faked, this broke
accessibility (as well as being quite messy).

In the new code items all handle their own key handling. Anything
unhandled propagates to the root view which then Keys.forwardTo the
relevant items.

Behaviour is mostly identical (except I changed escape in the
Applications view)

Change is too massive for 5.11, will delay for master.
mart accepted this revision.Sep 13 2017, 6:37 AM
mart added a subscriber: mart.

ok from me and yes, better to wait right after 5.11

This revision is now accepted and ready to land.Sep 13 2017, 6:37 AM

This got stuck because of some big kicker rewrite that happened in the meantime (and there's still some more on phab).

I'll abandon this then re-upload in smaller bite size chunks

davidedmundson abandoned this revision.Nov 29 2018, 2:14 PM