| mart |
| Plasma |
FocusProxy is added to all the Baseviews as an effective focus proxy to
forward focus to the contained Scrollview which in turn forwards it to
the relevant list view.
This gives focus to the relevant delegate.
Both tabs and items are exposed to the accessibilty tree.
Key handling still needs improvement, but that's somewhat separate.
Orca tells me tab when I change, and item when I change item
| No Linters Available |
| No Unit Test Coverage |
| applets/kickoff/package/contents/ui/ApplicationsView.qml | ||
|---|---|---|
| 26 | Edit: I did this because FullScreenRep was setting focus on this item explicitly. | |
In the old code sometimes the root item would mostly have focus, sometimes the relevant object. The root item would then perform key handling for everyone and dispatch events to the relevant place. Because focus kept ending up in the wrong place and faked, this broke accessibility (as well as being quite messy). In the new code items all handle their own key handling. Anything unhandled propagates to the root view which then Keys.forwardTo the relevant items. Behaviour is mostly identical (except I changed escape in the Applications view) Change is too massive for 5.11, will delay for master.
This got stuck because of some big kicker rewrite that happened in the meantime (and there's still some more on phab).
I'll abandon this then re-upload in smaller bite size chunks