make krunner accessible
ClosedPublic

Authored by mart on Sep 11 2017, 10:58 AM.

Details

Summary

this is the milou part: refine keyboard navigation and
semantically mark the entries with the correct text
to be read by orca

Test Plan

tested keyboard navigation and made sure orca reads the correct meaningful text

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Sep 11 2017, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2017, 10:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart updated this revision to Diff 19402.Sep 11 2017, 12:39 PM
  • reset list position on focus loss
broulik added inline comments.Sep 11 2017, 5:09 PM
lib/qml/ResultDelegate.qml
50

So we end up with " , in category foo" if subtextLabel is empty?

246

Not needed?

248

I don't understand this focus stuff at all but if it works..

lib/qml/ResultsView.qml
141

Can we perhaps bind the "isCurrentItem" to activeFocus instead of doing this in addition to incrementing/decrementing the index?

mart added inline comments.Sep 11 2017, 8:52 PM
lib/qml/ResultDelegate.qml
50

pretty much, i can make 2 different strings at all, the oddity if if it's a null string, i18n thinks it's a single patameter and complains about wrong parameters number

lib/qml/ResultsView.qml
141

will give a try

mart added inline comments.Sep 11 2017, 8:56 PM
lib/qml/ResultsView.qml
141

what i'm trying to do here is to focus the next item when cycling items with tabs arrives to the last item, so yeah, it's a bit hacky but works

mart updated this revision to Diff 19426.Sep 11 2017, 9:03 PM
  • better syntax on i18n
mart updated this revision to Diff 19429.Sep 11 2017, 9:18 PM
  • Accessible.ListItem as role
lib/qml/ResultDelegate.qml
50

This ends up in a different .pot file to the translation domain of krunner which is using this lib, I think you need to i18nd

mart updated this revision to Diff 19439.Sep 12 2017, 10:00 AM
  • add domain
mart updated this revision to Diff 19440.Sep 12 2017, 10:01 AM
  • domains
davidedmundson accepted this revision.Sep 12 2017, 10:02 AM
This revision is now accepted and ready to land.Sep 12 2017, 10:02 AM
This revision was automatically updated to reflect the committed changes.