this is the milou part: refine keyboard navigation and
semantically mark the entries with the correct text
to be read by orca
Details
Details
- Reviewers
davidedmundson broulik - Group Reviewers
Plasma - Commits
- R112:5946e684f8af: make krunner accessible
tested keyboard navigation and made sure orca reads the correct meaningful text
Diff Detail
Diff Detail
- Repository
- R112 Milou
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
lib/qml/ResultDelegate.qml | ||
---|---|---|
50 | So we end up with " , in category foo" if subtextLabel is empty? | |
246 | Not needed? | |
248 | I don't understand this focus stuff at all but if it works.. | |
lib/qml/ResultsView.qml | ||
141 | Can we perhaps bind the "isCurrentItem" to activeFocus instead of doing this in addition to incrementing/decrementing the index? |
lib/qml/ResultsView.qml | ||
---|---|---|
141 | what i'm trying to do here is to focus the next item when cycling items with tabs arrives to the last item, so yeah, it's a bit hacky but works |
lib/qml/ResultDelegate.qml | ||
---|---|---|
50 | This ends up in a different .pot file to the translation domain of krunner which is using this lib, I think you need to i18nd |