Move XRenderUtils init/cleanup into X11 standalone platform
ClosedPublic
Actions

Authored by graesslin on Sep 10 2017, 2:06 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:551a6246a897: Move XRenderUtils init/cleanup into X11 standalone platform

Summary

Only needed for kwin_x11 variant (required for the non-composited
Outline). As that's nowadays in the x11 platform, we can move the
complete XRenderUtils support into the platform. Thus KWin core does
no longer require to link it.

Test Plan

Compiles

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Sep 10 2017, 2:06 PM

Restricted Application added a project: KWin. · View Herald TranscriptSep 10 2017, 2:06 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

ping

graesslin added a dependent revision: D7924: Support starting kwin_wayland without XWayland support.Sep 21 2017, 4:33 PM

davidedmundson accepted this revision.Sep 21 2017, 4:45 PM

This revision is now accepted and ready to land.Sep 21 2017, 4:45 PM

Closed by commit R108:551a6246a897: Move XRenderUtils init/cleanup into X11 standalone platform (authored by graesslin). · Explain WhySep 22 2017, 1:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			plugins/platforms/x11/standalone/CMakeLists.txt (2 lines)
M			plugins/platforms/x11/standalone/x11_platform.cpp (4 lines)
M			plugins/platforms/x11/windowed/CMakeLists.txt (2 lines)
M			plugins/scenes/xrender/CMakeLists.txt (1 line)
M			workspace.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19361	95ae8da		Sep 10 2017, 2:06 PM	★	★
Diff 2	19789	0a6bd71	R108:551a6246a89796f726cf02b7d4b09b297800cb90	Sep 22 2017, 1:20 PM	★	★

Status	Author	Revision
Closed	graesslin	D7924 Support starting kwin_wayland without XWayland support
Closed	graesslin	D7760 Move XRenderUtils init/cleanup into X11 standalone platform
Closed	graesslin	D7894 Only try creating X11 shadow if we have an X11 connection
Closed	graesslin	D7892 Only call xcb_flush in performCompositing if we have an X11 connection
Closed	graesslin	D7897 Move X11 specific Workspace initialization code into dedicated method
Closed	graesslin	D7856 Make xstacking order dirty handling work without X11