Differential D7726

Fix ignoring of certain popup windows by the windowmapper
ClosedPublic
Actions

Authored by fvogt on Sep 7 2017, 7:33 PM.

Tags

Subscribers

Details

Reviewers

broulik
davidedmundson

Commits

R856:876423912bf5: Fix ignoring of certain popup windows by the windowmapper

Summary

At least on vivaldi 1.11, plasma-browser-extension broke popups
as the windowmapper page replaced the entire content and the popup
closed itself shortly thereafter.
Those popups have type === "normal", but the JSON-encoded extData
field has a windowType member that contains the truth...

Test Plan

Without this, google hangouts is broken. With this, google hangouts
works again.

Diff Detail

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fvogt created this revision.Sep 7 2017, 7:33 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 7 2017, 7:33 PM

Thanks for figuring that out :)

This revision is now accepted and ready to land.Sep 8 2017, 8:40 AM

Closed by commit R856:876423912bf5: Fix ignoring of certain popup windows by the windowmapper (authored by fvogt). · Explain WhySep 8 2017, 8:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			extension/extension.js (3 lines)

Diff 19299

extension/extension.js

Loading...