Fix visibility check of tracks in multitrack-view.
ClosedPublic
Actions

Authored by mghansen on Sep 3 2017, 9:04 AM.

Details

Reviewers

Group Reviewers

Summary

When using multi-track view, the last 4 visible tracks are arranged on a 2x2 grid. However, the existing code did not properly check for visibility of a track. This patch fixes that.

The patch is based on 118ce7d1d965a741907b03958f1ff738623f17c3.

Diff Detail

Repository

R158 Kdenlive

Lint

Lint Skipped

Unit

Unit Tests Skipped

mghansen created this revision.Sep 3 2017, 9:04 AM

mghansen added a commit: R158:118ce7d1d965: GIT_SILENT made messages (after extraction).Sep 3 2017, 9:07 AM

mghansen removed a commit: R158:118ce7d1d965: GIT_SILENT made messages (after extraction).

mghansen added a reviewer: Kdenlive.Sep 3 2017, 9:10 AM

mghansen added a project: Kdenlive.

Thanks for the patch, do you have commit access? 17.08.1 is scheduled for tomorrow so would be great to have this committed before.

This revision is now accepted and ready to land.Sep 3 2017, 9:27 AM

I do, but have not committed to any KDE projects for a few years. Would prefer if you could do the commit, since it is so short before release.

Ok, will do it tomorrow morning, thanks

Please remember to close things when you push them.

Revision Contents
Changeset List

			Path	Packages
M			src/timeline/transitionhandler.cpp (10 lines)

Diff 19118

View Options

src/timeline/transitionhandler.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19118			Sep 3 2017, 9:01 AM	★	★