Add syntax definition for Adblock Plus filter lists
ClosedPublic
Actions

Authored by vkrause on Sep 2 2017, 5:56 PM.

Details

Reviewers

mlaurent
dhaumann

Group Reviewers

Framework: Syntax Highlighting

Commits

Summary

This will allow us to replace the handwritten highlighter in the KDE PIM
adblocker plugin.

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

I guess this looks good.

I was pondering whether we need #pop#pop in the lineEndContext of context option-context, but if it works, it is probably fine...

This revision is now accepted and ready to land.Sep 2 2017, 7:37 PM

Ah, one question though: the .syntax file exists only for us as hint, or is it read by the unit test to specify the used highlighting ?

The .syntax files are read by the tests, for files that cannot be auto-detected.

Hm, and I thought I had used #pop!option-context for switching from exception to option context, but it indeed doesn't seem to make any difference.

This revision was automatically updated to reflect the committed changes.

		Path
A	M	autotests/folding/adblock.txt.fold (53 lines)
A	M	autotests/html/adblock.txt.html (60 lines)
A	M	autotests/input/adblock.txt (53 lines)
A	M	autotests/input/adblock.txt.syntax (1 line)
A	M	autotests/reference/adblock.txt.ref (53 lines)
A	M	data/syntax/adblock.xml (87 lines)