Rewrite the Sieve syntax definition
ClosedPublic
Actions

Authored by vkrause on Sep 2 2017, 3:26 PM.

Details

Reviewers

mlaurent
dhaumann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:abd5c3017df2: Rewrite the Sieve syntax definition

Summary

This brings the highlighting up-to-date with RFC 5228 as well as all
currently published extensions, and adds a few features found in the
handwritten highlighter in KDE PIM. It also adds support for variables
and encoded characters in strings, and fixes folding of multi-line
dot-stuffed strings.

A comprehensive test case based on examples from all relevant RFCs is
also included.

This now outperforms the handwritten highlighter in KDE PIM, and looks
also decent on dark color schemes, so we can hopefully port the PIM Sieve
editor to this :)

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Sep 2 2017, 3:26 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 2 2017, 3:26 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Looks good to me!

data/syntax/sieve.xml
147	You could add region="CommentRegion". Not a big deal, though.

This revision is now accepted and ready to land.Sep 2 2017, 4:10 PM

Closed by commit R216:abd5c3017df2: Rewrite the Sieve syntax definition (authored by vkrause). · Explain WhySep 2 2017, 6:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	autotests/folding/test.sieve.fold (387 lines)
A	M	autotests/html/test.sieve.html (394 lines)
A	M	autotests/input/test.sieve (387 lines)
A	M	autotests/reference/test.sieve.ref (387 lines)
M		data/syntax/sieve.xml (228 lines)