Differential D7645

Add highlighting for QDoc configuration files
ClosedPublic
Actions

Authored by vkrause on Sep 1 2017, 5:32 PM.

Details

Reviewers
dhaumann
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:251e5e1a9392: Add highlighting for QDoc configuration files

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Sep 1 2017, 5:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 1 2017, 5:32 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann accepted this revision.Sep 1 2017, 8:10 PM
dhaumann added a subscriber: dhaumann.

Looks good to me.

data/syntax/qdocconf.xml
15

Is the capital c intentional?

95

Given lineEndContext is pop, do we need the lineEmptyContext?

This revision is now accepted and ready to land.Sep 1 2017, 8:10 PM
vkrause added inline comments.Sep 1 2017, 8:29 PM
data/syntax/qdocconf.xml
15

yep, both according to the qdoc docs and real files

95

Yes, due to the LineContinue rule. The test case fails in two places without that, line 47 and 57, the empty line preceding those doesn't pop due to the line continuation the line before.

dhaumann added inline comments.Sep 1 2017, 8:35 PM
data/syntax/qdocconf.xml
95

Ah. Nice. So this is also a nice test for a corner case. Cool.

Closed by commit R216:251e5e1a9392: Add highlighting for QDoc configuration files (authored by vkrause). · Explain WhySep 2 2017, 9:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19084

View Options

autotests/folding/test.qdocconf.fold

Loading...
View Options

autotests/html/test.qdocconf.html

Loading...
View Options

autotests/input/test.qdocconf

Loading...
View Options

autotests/reference/test.qdocconf.ref

Loading...
View Options

data/syntax/qdocconf.xml

Loading...