Differential D7642

[ksycoca] Use QDateTime::currentDateTimeUtc
AbandonedPublic
Actions

Authored by broulik on Sep 1 2017, 2:26 PM.

Details

Reviewers
kde-frameworks-devel
dfaure
Test Plan

Tests still pass
Changed a file in /usr/share/applications, it would still notice that

Diff Detail

Repository
R309 KService
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 1 2017, 2:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 1 2017, 2:26 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure requested changes to this revision.Sep 3 2017, 8:00 AM
dfaure added a subscriber: dfaure.

Please use arc diff to upload patches so that context is available.

m_now isn't used to detect changes, but to detect files "in the future".
With your changes, the line if (mtime > m_now) will have to convert mtime to UTC first. It seems to me that you traded away one timezone conversion for thousands.
Did you measure this?

What we really need is QFileInfo::lastModifiedUtc(), assuming of course it would be able to do that without conversion...

This revision now requires changes to proceed.Sep 3 2017, 8:00 AM
broulik abandoned this revision.Dec 20 2017, 10:10 AM

Revision Contents
Changeset List

PathPackages
Msrc/sycoca/ksycoca.cpp (2 lines)

Diff 19049

View Options

src/sycoca/ksycoca.cpp

Loading...