[Folder View] Accept and reject Escape event appropriately

Authored by broulik on Aug 31 2017, 2:03 PM.



When renaming, accept the Escape key event to prevent the containment from leaving Showing Desktop mode. Otherwise don't accept it and let the containment do its thing.

BUG: 352988
FIXED-IN: 5.11.0

Test Plan

Depends on D7630

(And I thought it was KWin doing that with the Escape key..)

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 31 2017, 2:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2017, 2:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Aug 31 2017, 5:04 PM

Does this have any ramifications in widget mode (panel, etc)?

It also improves the experience when in a panel. The popup won't just close when I press Escape while renaming but also first cancel the rename and then close the popup.

hein accepted this revision.Sep 2 2017, 4:56 AM

Nice then!

This revision is now accepted and ready to land.Sep 2 2017, 4:56 AM
This revision was automatically updated to reflect the committed changes.