Differential D7611

Port Appmenu model to QDBusServiceWatcher
ClosedPublic
Actions

Authored by davidedmundson on Aug 29 2017, 10:45 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:c453e9b5fb77: Port Appmenu model to QDBusServiceWatcher
Summary

QDBusConnection::serviceOwnerChanged is deprecated, with the intended
replacement being QDBusServiceWatcher. QDBusServiceWatcher only creates
a match rule for the relevant services, resulting in less noise and
wakeups.

(practically this has no impact as the the system tray also connects to
watch every service change, and that runs in the same process)

Test Plan

Ran appmenu
Had dolphin open showing the menu
Closed dolphin
menu immediately closed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 29 2017, 10:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Aug 30 2017, 8:12 AM
This revision is now accepted and ready to land.Aug 30 2017, 8:12 AM
Closed by commit R120:c453e9b5fb77: Port Appmenu model to QDBusServiceWatcher (authored by davidedmundson). · Explain WhyAug 30 2017, 8:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18948

View Options

applets/appmenu/plugin/appmenumodel.h

Loading...
View Options

applets/appmenu/plugin/appmenumodel.cpp

Loading...