Port Appmenu model to QDBusServiceWatcher
ClosedPublic

Authored by davidedmundson on Aug 29 2017, 10:45 PM.

Details

Summary

QDBusConnection::serviceOwnerChanged is deprecated, with the intended
replacement being QDBusServiceWatcher. QDBusServiceWatcher only creates
a match rule for the relevant services, resulting in less noise and
wakeups.

(practically this has no impact as the the system tray also connects to
watch every service change, and that runs in the same process)

Test Plan

Ran appmenu
Had dolphin open showing the menu
Closed dolphin
menu immediately closed

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Plasma. · View Herald TranscriptAug 29 2017, 10:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Aug 30 2017, 8:12 AM
This revision is now accepted and ready to land.Aug 30 2017, 8:12 AM
This revision was automatically updated to reflect the committed changes.