Differential D7572

Fix dependency loop
ClosedPublic
Actions

Authored by adridg on Aug 27 2017, 2:58 PM.

Details

Reviewers
staniek
Maniphest Tasks
T3743: Don't keep generated parser/scanner files in the source dir
Commits
R15:d7aca7ac843b: Fix dependency loop: do not mark non-generated source files as generated
Summary
  • Since sqlscanner.cpp isn't generated, don't claim it is.
  • The ninja backend for CMake detects dependency loops and refuses to build.
  • Same caveat as the other lines commented with TODO(GEN) applies.

Diff Detail

Repository
R15 KDb
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
adridg created this revision.Aug 27 2017, 2:58 PM
Restricted Application added a project: KDb. · View Herald TranscriptAug 27 2017, 2:58 PM
adridg updated this revision to Diff 18847.Aug 27 2017, 3:24 PM

Missed 4 other dependency-loop files.

staniek edited edge metadata.Aug 28 2017, 11:09 AM

Thanks Adriaan. Looks OK except for KDbConnectionData_sdc.cpp.

src/CMakeLists.txt
65

It's generated from KDbConnectionData.shared.h...

The rule is in kdb_create_shared_data_classes( ... KDbConnectionData.shared.h ...)

staniek requested changes to this revision.Aug 28 2017, 11:10 AM
This revision now requires changes to proceed.Aug 28 2017, 11:10 AM
staniek updated this revision to Diff 25632.Jan 19 2018, 12:14 PM
  • GIT_SILENT SDC file is really generated
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2018, 12:24 PM
Closed by commit R15:d7aca7ac843b: Fix dependency loop: do not mark non-generated source files as generated (authored by adridg, committed by staniek). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (10 lines)

Diff 18847

View Options

src/CMakeLists.txt

Loading...