Just show the plain output to the users, as he would see when invoking
the build tool inside the terminal.
Don't rewrite the output, always show the full output. I don't think
there's a reason to support rewriting the output altogether, it's only
misleading for the user.
As discussed in bug 354143
BUG: 354143
CCBUG: 194403
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I agree that this patch is the way to go. If the use of Action formats label member is removed in output filtering strategies, I don't think it is used anywhere else and can probably be removed altogether (Not 100% sure though).
@volden: Thanks for your input, well appreciated (your the original author after all!)
Yes, you're right, ActionFormat::label can be removed as well it seems. Will fix.
In ActionFormat ctor,you are initializing a Qstring with an int - is that intentional or? Actually I'm not sure that the toolgroup is needed as well.
Also, unrelated to your patch, I can see that there must be an error in the line: ActionFormat( 1, 2, QStringLiteral("^linking (.*)") ) since the numbers refer to match groups in the regular expression. As far as I can see there is only one match group in this regex.