| krop | |
| dfaure |
Replace QUrl kio_svnProtocol::makeSvnUrl() with svn::Path kio_svnProtocol::makeSvnPath() - the returned QUrl was converted to svn::Path anyway.
The svn::Path(QUrl) ctor did it wrong - e.g. it did not remove the query part of the url). Since we don't need it anymore, we can remove it :)
Test kioslave with gwenview - try to open a image from svn.kde.org:
gwenview "ksvn://svn.kde.org/home/kde/trunk/tests/calligratests/interoperability/images/photoshop/Content 001.png" also test with a local svn repository (ksvn+file:// ...) if available.
| No Linters Available |
| No Unit Test Coverage |
Are you sure about RemoveUserInfo? Some people have a username in their svn URL, that's for sure.
The rest looks OK to me.
RemoveAutority contains RemoveUserInfo | RemovePort, so you probably don't want that either.