Implements https://bugs.kde.org/show_bug.cgi?id=338153
Details
Details
Tested with cmake warnings (works fine) and c++ build errors (works fine).
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Rest LGTM, thanks!
outputview/outputmodel.cpp | ||
---|---|---|
313 | Coding style: Opening brace on same line {. (Not for the definition itself (cf. line 310), that is okay) | |
plugins/standardoutputview/outputwidget.cpp | ||
434 | Nitpick: Remove newline | |
plugins/standardoutputview/outputwidget.h | ||
84 | Now it is no longer just a "Direction" -- maybe call it "SelectionMode"? (better suggestions welcome) |
Comment Actions
Fix it, then ship it!
plugins/standardoutputview/outputwidget.h | ||
---|---|---|
90 ↗ | (On Diff #1761) | Rename 'direction', too |
Comment Actions
Hm. This didn't auto-close...
Fixed:
commit f3bbf469f42cff6ccff07054036b3a88d1b9c26a
Author: Mikhail Ivchenko <ematirov@gmail.com>
Date: Wed Jan 6 18:34:12 2016 +0400
[GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget.