[GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget.
ClosedPublic
Actions

Authored by mwolff on Jan 6 2016, 12:58 PM.

Details

Reviewers

ematirov
kfunk

Commits

Summary

Test Plan

Tested with cmake warnings (works fine) and c++ build errors (works fine).

Repository

R33 KDevPlatform

Lint

Lint Skipped

Unit

Unit Tests Skipped

ematirov retitled this revision from to [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget..

ematirov updated this object.

ematirov edited the test plan for this revision. (Show Details)

ematirov added a reviewer: kfunk.

ematirov set the repository for this revision to R33 KDevPlatform.

Rest LGTM, thanks!

outputview/outputmodel.cpp
313 ↗	(On Diff #1760)	Coding style: Opening brace on same line {. (Not for the definition itself (cf. line 310), that is okay)
plugins/standardoutputview/outputwidget.cpp
434 ↗	(On Diff #1760)	Nitpick: Remove newline
plugins/standardoutputview/outputwidget.h
84 ↗	(On Diff #1760)	Now it is no longer just a "Direction" -- maybe call it "SelectionMode"? (better suggestions welcome)

Fix coding style issues.

Fix it, then ship it!

plugins/standardoutputview/outputwidget.h
90	Rename 'direction', too

This revision is now accepted and ready to land.Jan 6 2016, 2:26 PM

kfunk commandeered this revision.Jan 6 2016, 5:10 PM

kfunk edited reviewers, added: ematirov; removed: kfunk.

This revision now requires review to proceed.Jan 6 2016, 5:10 PM

Hm. This didn't auto-close...

Fixed:

commit f3bbf469f42cff6ccff07054036b3a88d1b9c26a
Author: Mikhail Ivchenko <ematirov@gmail.com>
Date: Wed Jan 6 18:34:12 2016 +0400

[GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget.

this was merged

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			outputview/ioutputviewmodel.h (18 lines)
M			outputview/outputmodel.h (2 lines)
M			outputview/outputmodel.cpp (30 lines)
M			plugins/standardoutputview/outputwidget.h (10 lines)
M			plugins/standardoutputview/outputwidget.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1760			Jan 6 2016, 12:54 PM	★	★
Diff 2	1761			Jan 6 2016, 2:18 PM	★	★
Diff 3	17891	7a61a3f	R32:f3bbf469f42cff6ccff07054036b3a88d1b9c26a	Jan 6 2016, 3:09 PM	★	★