Differential D7509

Add a property to hide the PageRow separator matching AbstractListItem.
ClosedPublic
Actions

Authored by hein on Aug 24 2017, 12:24 PM.

Details

Reviewers
mart
Commits
R169:57d9bf1d73c8: Add a property to hide the PageRow separator matching AbstractListItem.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.Aug 24 2017, 12:24 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 24 2017, 12:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Aug 24 2017, 12:39 PM
davidedmundson added inline comments.
src/controls/PageRow.qml
96 ↗(On Diff #18670)

A bit misleading, as when container.level is 0 this isn't false.

mart added inline comments.Aug 24 2017, 1:01 PM
src/controls/PageRow.qml
96 ↗(On Diff #18670)

the wording should be
"True if the separator between pages should be visible"
when the level is 0 this is false anyways as this property is set and is the visible property of the separator item that follows this one

hein updated this revision to Diff 18682.Aug 24 2017, 3:46 PM

Fix prop description

mart accepted this revision.Aug 25 2017, 3:52 PM
This revision is now accepted and ready to land.Aug 25 2017, 3:52 PM
Closed by commit R169:57d9bf1d73c8: Add a property to hide the PageRow separator matching AbstractListItem. (authored by hein). · Explain WhyAug 26 2017, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/PageRow.qml (10 lines)

Diff 18682

View Options

src/controls/PageRow.qml

Loading...