Differential D7459

Use config.h more
ClosedPublic
Actions

Authored by kfunk on Aug 22 2017, 7:21 AM.

Details

Reviewers
cullmann
Commits
R39:0ee0be681108: Use config.h more
Summary

This also fixes an issue with regards to HAVE_FDATASYNC:

src/buffer/katesecuretextbuffer.cpp:157:5:
warning: 'HAVE_FDATASYNC' is not defined, evaluates to 0 [-Wundef]
#if HAVE_FDATASYNC

^

> The code path with fdatasync() was never enabled in that file prior

to this patch

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Aug 22 2017, 7:21 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 22 2017, 7:21 AM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
cullmann accepted this revision.Aug 22 2017, 7:56 AM
cullmann added a subscriber: cullmann.

Looks reasonable.

This revision is now accepted and ready to land.Aug 22 2017, 7:56 AM
Closed by commit R39:0ee0be681108: Use config.h more (authored by kfunk). · Explain WhyAug 22 2017, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18529

View Options

config.h.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/buffer/katesecuretextbuffer.cpp

Loading...
View Options

src/document/katedocument.cpp

Loading...
View Options

src/swapfile/kateswapfile.cpp

Loading...
View Options

src/utils/kateglobal.cpp

Loading...