Drop boolean parameter from AbstractClient::caption
ClosedPublic
Actions

Authored by graesslin on Aug 20 2017, 7:36 AM.

Details

Reviewers

None

Group Reviewers

KWin
Plasma

Commits

R108:f0652970f4f0: Drop boolean parameter from AbstractClient::caption

Summary

With the latest refactoring AbstractClient::captionNormal is the same as
AbstractClient::caption(false) used to be. As there were only two usages
of the false parameter, let's remove this boolean trap and use proper
API calls.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Aug 20 2017, 7:36 AM

Restricted Application added a project: KWin. · View Herald TranscriptAug 20 2017, 7:36 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D7426: Make AbstractClient::caption no longer a virtual method.Aug 20 2017, 7:37 AM

Closed by commit R108:f0652970f4f0: Drop boolean parameter from AbstractClient::caption (authored by graesslin). · Explain WhySep 1 2017, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (2 lines)
M			abstract_client.cpp (15 lines)
M			client.cpp (2 lines)
M			rules.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18422	5d327ae		Aug 20 2017, 7:36 AM	★	★
Diff 2	19057	a7b29e0	R108:f0652970f4f0a22ad0e90fc7e012e8c2997dc8e5	Sep 1 2017, 3:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fc8752fa5328	2cc4d3d485c0	5d327aeb9452	Martin Flöser	Drop boolean parameter from AbstractClient::caption (Show More…)	Aug 20 2017, 7:35 AM

Status	Author	Revision
Closed	graesslin	D7427 Drop boolean parameter from AbstractClient::caption
Closed	graesslin	D7426 Make AbstractClient::caption no longer a virtual method
Closed	graesslin	D7425 Add <number> to Wayland captions if the caption is the same