Add <number> to Wayland captions if the caption is the same

Authored by graesslin on Aug 20 2017, 7:02 AM.



Bringing another caption feature from X11 to Wayland. If we have
multiple windows with the same caption, starting from the second window
a suffix <number> is added.

E.g. if we have three windows with caption "foo", the naming is:

  • foo
  • foo <2>
  • foo <3>

The change tries to use as much shared code between the X11 and Wayland
implementation. Unfortunately it's not possible to share completely as
the X11 implementation does X11 specific things like editing the visible

By sharing the code the numbering also works cross windowing system.
That is if a window is called "foo" on X11, a new window on Wayland with
caption "foo" will get adjusted to "foo <2>" and vice versa.

The change also eliminates a duplicated signal for captionChanged in
ShellClient (found by test case).

By using the shared implementation on X11 side a bug gets fixed which
got introduced with the support of "unresponsive", this is no longer
considered and the numbering still works even if there is a window which
is unresponsive.

Test Plan

New test case and manual testing

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 20 2017, 7:02 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 20 2017, 7:02 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

the numbering works for same caption for windows on X11 and Wayland.

This revision was automatically updated to reflect the committed changes.