If the application runs on Wayland, check whether the
ServerSideDecoration protocol is supported. If that's the case, disable
Qt's decoration and tell the Wayland server to use Server side decoration
for normal windows and no decoration for popus, etc.
Details
Details
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 95 | since is a long name already, going all the way, waylandserverdecoration ? | |
Comment Actions
I'd prefer a hard dependency, not build time, to make it harder to screw this up. We're already depending on kwayland hard in libkscreen and kwin, so it's needed anyway to build Plasma. Besides, it's small and lives right next to this repo.
Build system can be simplified a bit, code itself looks good to me.
| CMakeLists.txt | ||
|---|---|---|
| 36 | KWayland 5.6? (Not sure if the version is updated yet, if not, ignore and fix later) | |
| 37 | Why not use KF5Wayland_FOUND right away? | |
| autotests/CMakeLists.txt | ||
| 57 | (minor) indentation inconsistent with the bits above | |
Comment Actions
Awesome.
| src/platformtheme/kdeplatformtheme.cpp | ||
|---|---|---|
| 45 | Not sure what this header was used for, but should it not still be included? | |