| Frameworks |
Modernises the use of debugging classes in audiocd-kio (cf. D7380).
I've named the category the way most kioslaves seem to name their categories, using the kf5 toplevel domain rather than org.kde mostly because it's shorter and leaves no doubt that messages come from the KF5 version of the slave.
Works as intended.
I haven't checked if this removes the last dependency on kdelibs4support, does it?
| Lint Skipped |
| Unit Tests Skipped |
| CMakeLists.txt | ||
|---|---|---|
| 84 | I would follow a bit more the (unwritten, but used) convention from other projects: Please use org.kde; kf5, so far, has mostly been used for Framworks. I'd suggest to call the generated file <something>_logging (or <something>_debug) as it was done elsewhere. And the identifier could be AUDIOCD_LOG as well. | |
| audiocd.cpp | ||
| 59 | Is this needed when the generated logging header is included? | |