Differential D7361

Get rid of QSignalMapper
ClosedPublic
Actions

Authored by broulik on Aug 17 2017, 9:48 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R242:1419135a5d99: Get rid of QSignalMapper

Summary

Use lambdas instead.

Test Plan

This is slightly faster.

Verified that applet actions are still added and can be triggered.
Verified that wallpaper actions are still added and can be triggered.

Is it intentional that in AppletInterface removeAction does not remove them from the KActionCollection but only m_actions QStringList? This is only done in the WallpaperInterface.

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Aug 17 2017, 9:48 AM

Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptAug 17 2017, 9:48 AM

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

Is it intentional that in AppletInterface removeAction does not remove them from the KActionCollection but only m_actions QStringList? This is only done in the WallpaperInterface.

It does implicitly. KactionCollection watches for actions being destroyed.

davidedmundson accepted this revision.Aug 18 2017, 12:31 AM

This revision is now accepted and ready to land.Aug 18 2017, 12:31 AM

Closed by commit R242:1419135a5d99: Get rid of QSignalMapper (authored by broulik). · Explain WhyAug 18 2017, 9:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/scriptengines/qml/plasmoid/appletinterface.h (2 lines)
M			src/scriptengines/qml/plasmoid/appletinterface.cpp (23 lines)
M			src/scriptengines/qml/plasmoid/wallpaperinterface.h (2 lines)
M			src/scriptengines/qml/plasmoid/wallpaperinterface.cpp (18 lines)