CHANGELOG: Changing the "Show icons in menus" setting will now immediately be applied to running applications
Details
Details
Changed the "Show icons in menus" settings and menu immediately lost all its menu icons. Enabling the setting brought them back.
Follow-up patch will remove the notification about how this applies only to newly started applications.
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/platformtheme/khintssettings.cpp | ||
---|---|---|
357 | If I do removeKey("ShowIconsInMenu") rather than explicitly setting it then call settings changed, this will always remain on whatever it was before; rather than matching what the actual default should be. |
src/platformtheme/khintssettings.cpp | ||
---|---|---|
357 | So the default value should be true instead? (This has been a bug before then, though) |
Comment Actions
It wasn't a bug before because it was using whatever Qt had set as a default value; but that only works when you only have that line once.