Differential D7326

[File KIO slave] Fix applying special file attributes
ClosedPublic
Actions

Authored by broulik on Aug 15 2017, 12:18 PM.

Details

Reviewers
kde-frameworks-devel
dfaure
Commits
R241:9ac7832b859b: [File KIO slave] Fix applying special file attributes
Summary

QFile does not support special attributes like sticky. This would cause us to always discard them.

BUG: 365795

Test Plan

Comes with a unit test that passes only with this patch. Did not try windows compilation.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 15 2017, 12:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 15 2017, 12:18 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Aug 15 2017, 12:25 PM
This revision is now accepted and ready to land.Aug 15 2017, 12:25 PM
Closed by commit R241:9ac7832b859b: [File KIO slave] Fix applying special file attributes (authored by broulik). · Explain WhyAug 15 2017, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/jobtest.h (3 lines)
Mautotests/jobtest.cpp (20 lines)
Msrc/ioslaves/file/file.cpp (5 lines)

Diff 18187

View Options

autotests/jobtest.h

Loading...
View Options

autotests/jobtest.cpp

Loading...
View Options

src/ioslaves/file/file.cpp

Loading...