Differential D7307

Allow the editor model to add/remove attachments
ClosedPublic
Actions

Authored by ervin on Aug 14 2017, 3:55 PM.

Details

Reviewers
dfaure
bensi
franckarrecot
Commits
R4:d96e8b148361: Allow the editor model to add/remove attachments
Summary

We could list and open them but not really manage them within Zanshin,
this is one step to solve this.

Diff Detail

Repository
R4 Zanshin
Lint
Lint Skipped
Unit
Unit Tests Skipped
ervin created this revision.Aug 14 2017, 3:55 PM
bensi accepted this revision.Aug 15 2017, 8:45 AM
This revision is now accepted and ready to land.Aug 15 2017, 8:45 AM
dfaure requested changes to this revision.Aug 15 2017, 12:30 PM
dfaure added inline comments.
src/presentation/artifacteditormodel.cpp
333

missing error reporting to the user (unlikely error though... maybe at least a qWarning?)

tests/units/presentation/artifacteditormodeltest.cpp
631

(a setAutosaveDelay(50) would speed up the unittest by a factor of 10)

This revision now requires changes to proceed.Aug 15 2017, 12:30 PM
ervin added inline comments.Aug 16 2017, 7:51 AM
tests/units/presentation/artifacteditormodeltest.cpp
631

I'll do that in another commit, other tests are affected too.

ervin updated this revision to Diff 18255.Aug 16 2017, 7:47 PM
ervin edited edge metadata.

Addressing dfaure's comment

dfaure accepted this revision.Aug 16 2017, 9:19 PM
This revision is now accepted and ready to land.Aug 16 2017, 9:19 PM
Closed by commit R4:d96e8b148361: Allow the editor model to add/remove attachments (authored by ervin). · Explain WhyAug 16 2017, 11:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18255

View Options

src/presentation/artifacteditormodel.h

Loading...
View Options

src/presentation/artifacteditormodel.cpp

Loading...
View Options

tests/units/presentation/artifacteditormodeltest.cpp

Loading...