Add support for moving group members within a group.

Authored by hein on Aug 12 2017, 12:31 AM.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Aug 12 2017, 12:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 12 2017, 12:31 AM
davidedmundson added inline comments.Aug 12 2017, 7:16 AM

This is the only bit that's different from the new code.

Can we share the above and guard this with if(!parent)

hein added inline comments.Aug 14 2017, 7:11 AM

I was uncomfortable just always passing parent through in beginMoveRows without guarding that with a check, too, but OK ...

hein updated this revision to Diff 18120.Aug 14 2017, 7:44 AM

Reduce code duplication.

A bit queasy about just passing through parent though.

If you don't want to do it, don't do it.

Though I don't really understand what your concern is. If the parent is invalid, then it's invalid. The code will be the same.

davidedmundson accepted this revision.Aug 14 2017, 7:56 AM

+2 on either patch.

This revision is now accepted and ready to land.Aug 14 2017, 7:56 AM
This revision was automatically updated to reflect the committed changes.