EditorView now displays attachments
ClosedPublic
Actions

Authored by ervin on Aug 11 2017, 10:59 PM.

Details

Reviewers

Commits

R4:db8db78e8393: EditorView now displays attachments

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

dfaure added inline comments.

src/widgets/editorview.cpp
120	why the else, given the return in the if block? All the rest of the method is what happens with a model set, there's little reason to have some code in the else and some code after the else...

This revision is now accepted and ready to land.Aug 12 2017, 10:04 PM

Addresses dfaure's comments

Tune a bit the attachment list display

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/widgets/editorview.cpp (4 lines)
M			src/widgets/editorview.ui (26 lines)
M			tests/units/widgets/editorviewtest.cpp (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18029	8bf01d1		Aug 11 2017, 10:59 PM	★	★
Diff 2	18113	ae47e9d	Addresses dfaure's comments	Aug 13 2017, 11:06 PM	★	★
Diff 3	18119	ae47e9d	Tune a bit the attachment list display	Aug 13 2017, 11:24 PM	★	★
Diff 4	18263	9a7e6b4	R4:db8db78e83932450a5f7bc925ddd3c04d4eb1e2f	Aug 16 2017, 10:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
cae45d0e8139	f86400279db2	8bf01d1462ff	Kevin Ottens	EditorView now displays attachments	Aug 11 2017, 10:24 PM