Differential D7262

Have AkonadiSerializer process Attachments
ClosedPublic
Actions

Authored by ervin on Aug 11 2017, 10:58 PM.

Details

Reviewers
dfaure
bensi
franckarrecot
Commits
R4:b2e2595c7f55: Have AkonadiSerializer process Attachments

Diff Detail

Repository
R4 Zanshin
Lint
Lint Skipped
Unit
Unit Tests Skipped
ervin created this revision.Aug 11 2017, 10:58 PM
dfaure requested changes to this revision.Aug 12 2017, 9:42 PM
dfaure added inline comments.
src/akonadi/akonadiserializer.cpp
206

attachments.reserve(todo->attachments().count());

tests/units/akonadi/akonadiserializertest.cpp
717

this is unused (it should be used below)

819

this just duplicates the logic of the implementation, much better to actually use the list of expected values here.

This revision now requires changes to proceed.Aug 12 2017, 9:42 PM
ervin updated this revision to Diff 18112.Aug 13 2017, 11:06 PM
ervin edited edge metadata.

Addresses dfaure's comments

dfaure accepted this revision.Aug 14 2017, 10:52 AM

The two big duplicated blocks of code in the "THEN" could be factorized with a lambda or just with for (auto t : {task, artifact.dynamicCast<Domain::Task>()}) { ... } I think.

This revision is now accepted and ready to land.Aug 14 2017, 10:52 AM
bensi accepted this revision.Aug 14 2017, 3:39 PM
Closed by commit R4:b2e2595c7f55: Have AkonadiSerializer process Attachments (authored by ervin). · Explain WhyAug 16 2017, 11:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18112

View Options

src/akonadi/akonadiserializer.cpp

Loading...
View Options

tests/units/akonadi/akonadiserializertest.cpp

Loading...