Have AkonadiSerializer process Attachments
ClosedPublic

Authored by ervin on Aug 11 2017, 10:58 PM.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Aug 11 2017, 10:58 PM
dfaure requested changes to this revision.Aug 12 2017, 9:42 PM
dfaure added inline comments.
src/akonadi/akonadiserializer.cpp
206

attachments.reserve(todo->attachments().count());

tests/units/akonadi/akonadiserializertest.cpp
717

this is unused (it should be used below)

819

this just duplicates the logic of the implementation, much better to actually use the list of expected values here.

This revision now requires changes to proceed.Aug 12 2017, 9:42 PM
ervin updated this revision to Diff 18112.Aug 13 2017, 11:06 PM
ervin edited edge metadata.

Addresses dfaure's comments

dfaure accepted this revision.Aug 14 2017, 10:52 AM

The two big duplicated blocks of code in the "THEN" could be factorized with a lambda or just with for (auto t : {task, artifact.dynamicCast<Domain::Task>()}) { ... } I think.

This revision is now accepted and ready to land.Aug 14 2017, 10:52 AM
bensi accepted this revision.Aug 14 2017, 3:39 PM
This revision was automatically updated to reflect the committed changes.