Differential D7196

Fix accepting dialogs with ctrl+return when buttons are renamed
ClosedPublic
Actions

Authored by apol on Aug 8 2017, 1:54 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R252:7524bf1535b4: Fix accepting dialogs with ctrl+return when buttons are renamed
Summary

QAbstractButton::setText will call setShortcut(mnemonic), making this
little hack unusable.
This patch puts the shortcut into a separate object.

Test Plan

Improved the test to reproduce the issue I had
Now we can use it with KDE Connect send reply dialogs

Diff Detail

Repository
R252 Framework Integration
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Aug 8 2017, 1:54 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 8 2017, 1:54 AM
apol updated this revision to Diff 17862.Aug 8 2017, 2:00 AM

Make sure there's such a button

dfaure accepted this revision.Aug 9 2017, 8:14 AM
This revision is now accepted and ready to land.Aug 9 2017, 8:14 AM
Closed by commit R252:7524bf1535b4: Fix accepting dialogs with ctrl+return when buttons are renamed (authored by apol). · Explain WhyAug 9 2017, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (7 lines)
Mtests/kstyletest.cpp (13 lines)

Diff 17862

View Options

src/kstyle/kstyle.cpp

Loading...
View Options

tests/kstyletest.cpp

Loading...