Differential D7195

KUndoActions: use actionCollection to set the shortcut
ClosedPublic
Actions

Authored by ltoscano on Aug 7 2017, 8:31 PM.

Details

Reviewers
aacid
Commits
R263:f2b5114d8b90: KUndoActions: use actionCollection to set the shortcut
Summary

Resolve the following warning printed out when the undo/redo actions
are added through KUndoActions:

KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for
action "edit_undo" "Undo" set with QAction::setShortcut()!
Use KActionCollection::setDefaultShortcut(s) instead.

Test Plan

The undo/redo actions still work and the warning is gone.

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Aug 7 2017, 8:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 7 2017, 8:31 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
aacid accepted this revision.Aug 7 2017, 9:14 PM
This revision is now accepted and ready to land.Aug 7 2017, 9:14 PM
Closed by commit R263:f2b5114d8b90: KUndoActions: use actionCollection to set the shortcut (authored by ltoscano). · Explain WhyAug 7 2017, 9:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kundoactions.cpp (4 lines)

Diff 17859

View Options

src/kundoactions.cpp

Loading...