Differential D7178

Fallback for cached icons
ClosedPublic
Actions

Authored by jgrulich on Aug 7 2017, 9:04 AM.

Details

Reviewers
apol
Commits
R134:852973152c6c: Fallback for cached icons
Summary

Apparently some appstream metadata might have icon information in form of
<icon height="128" width="128" type="cached">org.gnome.gedit</icon>
instead of
<icon height="128" width="128" type="cached">128x128/org.gnome.gedit</icon>
which leads into missing icon as we are looking into wrong location.

Diff Detail

Repository
R134 Discover Software Store
Branch
appstream-icons
Lint
No Linters Available
Unit
No Unit Test Coverage
jgrulich created this revision.Aug 7 2017, 9:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 7 2017, 9:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Aug 7 2017, 10:30 AM
This revision is now accepted and ready to land.Aug 7 2017, 10:30 AM
Closed by commit R134:852973152c6c: Fallback for cached icons (authored by jgrulich). · Explain WhyAug 7 2017, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17815

View Options

libdiscover/backends/FlatpakBackend/FlatpakResource.cpp

Loading...