Differential D7085

Fix issue where notifications will show as 1 pixel line
AbandonedPublic
Actions

Authored by davidedmundson on Aug 2 2017, 10:43 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Dialog::setVisible doesn't do anything if the QML hasn't finished
setting initial properties (componentCompleted)

componentComplete() method used to duplicate the code that was in
Dialog::setVisible().

Dialog::setVisible was changed in
eab4aa9909a62cce9b32555ed28d142569fb467f. componentComplete was not.

Rather than copying the code, we can call the method directly.

BUG: 382340

Test Plan

Popups are exactly the same on my system, but as I couldn't reliably reproduce the original bug that
doesn't really prove anything useful

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Aug 2 2017, 10:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 2 2017, 10:43 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson added a comment.Aug 3 2017, 8:56 AM

Apparently doesn't fix the bug that brought me here.

To me the code still makes sense, but equally I don't want to touch this clearly cursed class any more than possible.

mart added a reviewer: Plasma.Aug 4 2017, 8:14 AM
davidedmundson abandoned this revision.Feb 10 2018, 11:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2018, 11:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/dialog.cpp (9 lines)

Diff 17603

View Options

src/plasmaquick/dialog.cpp

Loading...