Differential D7064

[Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel
ClosedPublic
Actions

Authored by broulik on Aug 2 2017, 9:15 AM.

Details

Reviewers

hein

Group Reviewers

Plasma

Commits

R119:103c19119d67: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel

Summary

We already have a ready-to-use filter model for that.
While at it, make the filter case-insensitive.

Test Plan

Typing a filter filters the list
Clearing the filter shows all items again
Checking/unchecking filters enables apply button
The filters are correctly applied

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Aug 2 2017, 9:15 AM

Restricted Application added a project: Plasma. · View Herald TranscriptAug 2 2017, 9:15 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

hein accepted this revision.Aug 2 2017, 9:20 AM

This revision is now accepted and ready to land.Aug 2 2017, 9:20 AM

Closed by commit R119:103c19119d67: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel (authored by broulik). · Explain WhyAug 2 2017, 9:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			containments/desktop/package/contents/ui/ConfigFilter.qml (15 lines)
M			containments/desktop/plugins/folder/folderplugin.cpp (2 lines)
M			containments/desktop/plugins/folder/mimetypesmodel.h (28 lines)
M			containments/desktop/plugins/folder/mimetypesmodel.cpp (45 lines)