Add KF5WebKit as fallback
ClosedPublic

Authored by wojnilowicz on Jul 29 2017, 9:00 AM.

Details

Reviewers
None
Group Reviewers
KMyMoney
Commits
R261:e100db326a70: Add KF5WebKit as fallback
Summary

BUG:382747
FIXED-IN:5.0

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz created this revision.Jul 29 2017, 9:00 AM

Idea: use a typedef to change the many #if/#else blocks to a general form.

From

#ifdef ENABLE_WEBENGINE
QWebEngineView            *m_tableView;
#else
KWebView                  *m_tableView;
#endif

in many places to

#ifdef ENABLE_WEBENGINE
typedef QWebEngineView KMMPrintView;
#else
typedef KWebView KMMPrintView;
#endif

and

KMMPrintView                  *m_tableView;

... hit the submit button too early ...

to reduce the number of #if/#else blocks throughout the patch. In some it's still needed though due to different methods of the two objects.

I am not sure if placing the typedefs in config-kmymoney.h.cmake is the right solution and does not confuse cmake but that would make a nice place.

... hit the submit button too early ...

to reduce the number of #if/#else blocks throughout the patch. In some it's still needed though due to different methods of the two objects.

I am not sure if placing the typedefs in config-kmymoney.h.cmake is the right solution and does not confuse cmake but that would make a nice place.

I wouldn't elaborate on these things too much because it doesn't bring us nothing practical. This patch means to provide stable transition to new QWebEngine and routines here aren't meant to last forever.

This revision was automatically updated to reflect the committed changes.