Mass processing of data/files is better done in a job
(ideally one day also in own thread).
Details
Details
Works as before when e.g. invoked on toplevel project item,
Stopping the job works as well, happens right after the current
file being processed.
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Branch
- makeformattingajob
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Yes, there is more room for improvements here. So far SourceFormatterJob::formatFile() is simply the same logic as SourceFormatterController::formatFiles(), with the loop turned into kjob work slices.
Have to admit I am only starting to learn about KJob-style API, so would be happy if the patch could already be applied as it is right, unless there are regressions introduced.
There is surely room for more improvements, but I do not have resources reserved right now to turn the whole logic into perfect code in one go :)