Theme: Derive read-only flag from file on disk
ClosedPublic
Actions

Authored by dhaumann on Jul 26 2017, 8:34 AM.

Details

Reviewers

Commits

R216:34489c2a1cec: Theme: Derive read-only flag from file on disk

Summary

Instead of having a "read-only" flag in the .theme files, using the file location typically is exactly what we want.
And having read-only files in a writable location does not make much sense.

Test Plan

make test, adapted unit tests.

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dhaumann created this revision.Jul 26 2017, 8:34 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2017, 8:34 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

vkrause accepted this revision.Jul 26 2017, 9:10 AM

This revision is now accepted and ready to land.Jul 26 2017, 9:10 AM

Closed by commit R216:34489c2a1cec: Theme: Derive read-only flag from file on disk (authored by dhaumann). · Explain WhyJul 26 2017, 9:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/theme_test.cpp (3 lines)
M			data/themes/default.theme (5 lines)
M			data/themes/printing.theme (5 lines)
M			src/lib/theme.h (6 lines)
M			src/lib/themedata.cpp (5 lines)
M			src/lib/themedata_p.h (1 line)